Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: add eval to function map #1005

Merged
merged 1 commit into from May 12, 2022
Merged

perf: add eval to function map #1005

merged 1 commit into from May 12, 2022

Conversation

abichinger
Copy link
Member

@abichinger abichinger commented May 5, 2022 •
edited by hsluoyz

Fix: #1000

Benchmark results:

Before:
BenchmarkABACRuleModel-12    	      49	  21753411 ns/op	 4408055 B/op	  100021 allocs/op

After:
BenchmarkABACRuleModel-12    	     165	   7101567 ns/op	 1320970 B/op	   40087 allocs/op

Signed-off-by: Andreas Bichinger andreas.bichinger@gmail.com

@casbin-bot
Copy link
Member

@tangyang9464 @closetool @sagilio please review

@hsluoyz
Copy link
Member

hsluoyz commented May 5, 2022

@tangyang9464

tangyang9464
tangyang9464 suggested changes May 9, 2022
View reviewed changes
enforcer.go Outdated Show resolved Hide resolved
enforcer.go Outdated Show resolved Hide resolved
tangyang9464
tangyang9464 reviewed May 10, 2022
View reviewed changes
enforcer.go Outdated Show resolved Hide resolved
@abichinger
perf: add eval to function map
96d49cf 
Signed-off-by: Andreas Bichinger <andreas.bichinger@gmail.com>
@hsluoyz
Copy link
Member

hsluoyz commented May 12, 2022

@tangyang9464

tangyang9464
tangyang9464 approved these changes May 12, 2022
View reviewed changes
Copy link
Member

@tangyang9464 tangyang9464 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsluoyz hsluoyz merged commit 8413b34 into casbin:master May 12, 2022
@hsluoyz
Copy link
Member

hsluoyz commented May 12, 2022

@abichinger good work! Can you also update the benchmark at: https://casbin.org/docs/en/benchmark ?

@github-actions
Copy link

🎉 This PR is included in version 2.46.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@sagilio sagilio mentioned this pull request May 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangyang9464 tangyang9464 tangyang9464 approved these changes

@kilosonc kilosonc Awaiting requested review from kilosonc

@sagilio sagilio Awaiting requested review from sagilio

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Performance improvements
4 participants
@abichinger @casbin-bot @hsluoyz @tangyang9464