Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fetching artifacts by OS & architecture #157

Open
benmoss opened this issue May 2, 2022 · 3 comments
Open

Support fetching artifacts by OS & architecture #157

benmoss opened this issue May 2, 2022 · 3 comments
Labels
carvel-accepted This issue should be considered for future work and that the triage process has been completed discussion This issue is not a bug or feature and a conversation is needed to find an appropriate resolution enhancement This issue is a feature request

Comments

@benmoss
Copy link
Contributor

benmoss commented May 2, 2022

Describe the problem/challenge you have
I want my project to run on different platforms and so depending on which platform I am building for I want to download different artifacts.

For example, this vendir.yml pulls in kubectl for linux/amd64.

Describe the solution you'd like
I would prefer a solution where I don't have to download artifacts for all platforms, so maybe this needs to be an argument that's passed to vendir sync.

For the example given above it seems like we could allow this to work:

url: https://dl.k8s.io/release/{tag}/bin/{os}/{arch}/kubectl

Anything else you would like to add:
This probably only makes sense for certain kinds of artifacts: GitHub releases, HTTP maybe.


Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@benmoss benmoss added enhancement This issue is a feature request carvel-triage This issue has not yet been reviewed for validity labels May 2, 2022
@cppforlife
Copy link
Contributor

may be also would be good to scope {os}/{arch} to something like {vendir.os}/{vendir.arch}, since in the example of githubRelease+http, tag is derived from that "local" context of githubRelease.

probably also makes sense to have binary{vendir.os_ext} so that on windows it's .exe vs on linux nothing.

@cppforlife
Copy link
Contributor

interesting questions on this topic:

  • vendir.lock.yml relationship to what os/arch is set
  • how are values os/arch are set: auto, manually
  • should vendir have rename functionality (e.g. ytt-darwin-amd64 => ytt)

@github-actions github-actions bot added the stale This issue has had no activity for a while and will be closed soon label Jun 20, 2022
@cppforlife cppforlife added carvel-accepted This issue should be considered for future work and that the triage process has been completed and removed carvel-triage This issue has not yet been reviewed for validity stale This issue has had no activity for a while and will be closed soon labels Jun 21, 2022
@cppforlife cppforlife added the discussion This issue is not a bug or feature and a conversation is needed to find an appropriate resolution label Jul 1, 2022
@carvel-dev carvel-dev deleted a comment from github-actions bot Jul 1, 2022
@mamachanko
Copy link
Contributor

+1 to this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carvel-accepted This issue should be considered for future work and that the triage process has been completed discussion This issue is not a bug or feature and a conversation is needed to find an appropriate resolution enhancement This issue is a feature request
Projects
Status: Unprioritized
Development

No branches or pull requests

3 participants