Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort-semver skip numeric identifiers over unsigned long #117

Open
jvalkeal opened this issue Oct 15, 2021 · 1 comment
Open

sort-semver skip numeric identifiers over unsigned long #117

jvalkeal opened this issue Oct 15, 2021 · 1 comment
Labels
awaiting-input bug This issue describes a defect or unexpected behavior discussion This issue is not a bug or feature and a conversation is needed to find an appropriate resolution priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.

Comments

@jvalkeal
Copy link

What steps did you take:
If semver identifier in a metadata contains only numeric characters and if that "number" exceeds unsigned long (18,446,744,073,709,551,615), tools simply ignores that version.

$ vendir tools sort-semver -v "1.0.0+18446744073709551615" 
Versions

Version  
1.0.0+18446744073709551615  

Highest version: 1.0.0+18446744073709551615

Succeeded

$ vendir tools sort-semver -v "1.0.0+18446744073709551616" 
Versions

Version  

Succeeded

$ vendir tools sort-semver -v "1.0.0+18446744073709551615x" 
Versions

Version  
1.0.0+18446744073709551615x  

Highest version: 1.0.0+18446744073709551615x

Succeeded

$ vendir tools sort-semver -v "1.0.0+18446744073709551616x" 
Versions

Version  
1.0.0+18446744073709551616x  

Highest version: 1.0.0+18446744073709551616x

Succeeded

What happened:
Version is ignored

What did you expect:
Expecting metadata identifier to work with any alphanumeric characters

Environment:

  • vendir version 0.23.0
  • OS Ubuntu 18.04.3 LTS

Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@jvalkeal jvalkeal added bug This issue describes a defect or unexpected behavior carvel-triage This issue has not yet been reviewed for validity labels Oct 15, 2021
@cppforlife cppforlife added carvel-accepted This issue should be considered for future work and that the triage process has been completed and removed carvel-triage This issue has not yet been reviewed for validity labels Oct 22, 2021
@cppforlife
Copy link
Contributor

im guessing uint64 is used in underlying library (e.g. constant 18446744073709551616 overflows uint64 type of error). im actually not quite sure if we should do anything about this given practical limitations of how numbers are stored.

@jvalkeal what was your use case for using such large numbers. are they based on timestamps?

@cppforlife cppforlife added discussion This issue is not a bug or feature and a conversation is needed to find an appropriate resolution and removed carvel-accepted This issue should be considered for future work and that the triage process has been completed labels Oct 22, 2021
@neil-hickey neil-hickey added priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. awaiting-input labels Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-input bug This issue describes a defect or unexpected behavior discussion This issue is not a bug or feature and a conversation is needed to find an appropriate resolution priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.
Projects
Status: Unprioritized
Development

No branches or pull requests

3 participants