Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to create multiple keys in Secrets #30

Open
erkerb4 opened this issue Sep 14, 2021 · 2 comments
Open

Option to create multiple keys in Secrets #30

erkerb4 opened this issue Sep 14, 2021 · 2 comments
Labels
discussion This issue is not a bug or feature and a conversation is needed to find an appropriate resolution enhancement This issue is a feature request priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@erkerb4
Copy link

erkerb4 commented Sep 14, 2021

Describe the problem/challenge you have
When multiple keys are defined in a Password object, the generated secrets are the same across all keys.

Here is an example:

---
apiVersion: secretgen.k14s.io/v1alpha1
kind: Password
metadata:
  name: postgresql-password
spec:
  secretTemplate:
    type: Opaque
    stringData:
      postgresql-password: $(value)
      postgresql-postgres-password: $(value)
      repmgr-password: $(value)

What is currently generated:

apiVersion: v1
data:
  postgresql-password: ZDJ1cjJiZm1keHFpb2F3cnNtZGYxMHN0YTl0Z2J1anB0cWx3aGdjbA==
  postgresql-postgres-password: ZDJ1cjJiZm1keHFpb2F3cnNtZGYxMHN0YTl0Z2J1anB0cWx3aGdjbA==
  repmgr-password: ZDJ1cjJiZm1keHFpb2F3cnNtZGYxMHN0YTl0Z2J1anB0cWx3aGdjbA==
kind: Secret
  name: postgresql-password
type: Opaque

Describe the solution you'd like
It would be fantastic, if each key in the secret would get a unique password.

Anything else you would like to add:
N/A

Thank you for your hard work!

@erkerb4 erkerb4 added carvel-triage This issue has not yet been reviewed for validity enhancement This issue is a feature request labels Sep 14, 2021
@cppforlife
Copy link
Contributor

@erkerb4 that becomes becomes of an issue for generating multiple passwords and combining them into a single secret (via a template). we've considered adding something like SecretTemplate CR (or something similar) which would be able to aggregate contents of one or more secrets Secrets and produce a new one, but have not fully committed to that approach yet.

@erkerb4
Copy link
Author

erkerb4 commented Sep 22, 2021

Will be eagerly awaiting that implementation. Thank you for your response.

@joe-kimmel-vmw joe-kimmel-vmw added discussion This issue is not a bug or feature and a conversation is needed to find an appropriate resolution and removed carvel-triage This issue has not yet been reviewed for validity labels Dec 22, 2021
@neil-hickey neil-hickey added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion This issue is not a bug or feature and a conversation is needed to find an appropriate resolution enhancement This issue is a feature request priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
Status: Unprioritized
Development

No branches or pull requests

4 participants