Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to kbld that disables appending image SHAs to yaml in stdout #181

Open
bcdurden opened this issue Oct 20, 2021 · 1 comment
Open
Labels
discussion This issue is not a bug or feature and a conversation is needed to find an appropriate resolution enhancement This issue is a feature request

Comments

@bcdurden
Copy link

Describe the problem/challenge you have
I am attempting to create a bundle that can be moved across an airgap. This means I need a valid configuration yaml as well as transposed images when running in my airgapped environment where the bundle uses my existing internal registry instead.

To do this, I have to use the helm template output fed into kbld in order to generate an ImageLock object. As part of the stdout output of kbld, it also passes the incoming helm chart out to console. However, this output has been modified from the original helm chart in that the images within now have SHAs appended to them.

This is problematic when creating a true bundle as I cannot use this output. When using this bundle inside the airgap environment, this kbld output with SHA values would fail to resolve the imagelock object I am using in the bundle. To work around this, I need an extra step where I run the helm command again but output directly to a file instead of kbld.

Describe the solution you'd like
It would be a much cleaner solution to add a flag to kbld that disables any image alteration of the incoming yaml it receives from stdin or a file. I can then output that result directly to a file and have my needed imagelock object in one clean step instead of multiple helm calls.


Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@bcdurden bcdurden added carvel triage This issue has not yet been reviewed for validity enhancement This issue is a feature request labels Oct 20, 2021
@pivotaljohn pivotaljohn added discussion This issue is not a bug or feature and a conversation is needed to find an appropriate resolution and removed carvel triage This issue has not yet been reviewed for validity labels Oct 25, 2021
@pivotaljohn
Copy link
Contributor

Hey @bcdurden. I see that you want to be able to do two things with the output of your helm template ...:

  • run once through kbld to resolve references into a lock file, and
  • save the templated results to be an artifact of the bundle itself.

But that this would require to invocations of helm template to do so.

Exploring our options: how much of a burden would it be for the users of your bits to employ the tee tool?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion This issue is not a bug or feature and a conversation is needed to find an appropriate resolution enhancement This issue is a feature request
Projects
Status: To Triage
Development

No branches or pull requests

2 participants