Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kapp tries to list resources from deprecated api versions #864

Open
praveenrewar opened this issue Nov 20, 2023 · 5 comments
Open

kapp tries to list resources from deprecated api versions #864

praveenrewar opened this issue Nov 20, 2023 · 5 comments
Assignees
Labels
bug This issue describes a defect or unexpected behavior carvel accepted This issue should be considered for future work and that the triage process has been completed priority/important-soon Must be staffed and worked on currently or soon.

Comments

@praveenrewar
Copy link
Member

What steps did you take:
I tried deploying an app that consists of a horizontal pod autoscaler (api version v2) on a Kubernetes cluster v1.25.

What happened:
kapp tries to make a list call to /apis/autoscaling/v2beta2/horizontalpodautoscalers which is deprecated and there's no resource in my app with this apiVersion.

What did you expect:
I expected kapp to only list the api versions that are part of my app.

Anything else you would like to add:
Currently we scope list calls to unique GKs, so we try to make a list call for all versions. We need to be smart enough to exclude such deprecated apis.

Environment:

  • kapp version (use kapp --version):
  • OS (e.g. from /etc/os-release):
  • Kubernetes version (use kubectl version)

Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@praveenrewar praveenrewar added bug This issue describes a defect or unexpected behavior carvel accepted This issue should be considered for future work and that the triage process has been completed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Nov 20, 2023
@rcmadhankumar rcmadhankumar self-assigned this Dec 26, 2023
@100mik
Copy link
Contributor

100mik commented Jan 10, 2024

We should be conscious about how this affects diffing during migrating CRs from to a newer api version. We should probably verify how ignoring older versions would affect diffs and the end result.
cc: @rcmadhankumar

@tylerphelan
Copy link

this blocks automatic upgrades on gke when using kapp

@100mik
Copy link
Contributor

100mik commented Feb 27, 2024

@tylerphelan could you be more specific about the scenario here?

We might have flags that you can use during an upgrade consciously to help it go through.

@tylerphelan
Copy link

@100mik gke checks for uses of deprecated apis in the last 30 days and blocks auto-upgrading the k8s cluster if there are any so when we're using kapp all the time GKE never auto-upgrades our clusters off of deprecated versions.

@100mik
Copy link
Contributor

100mik commented Mar 5, 2024

That is helpful, we might have to think about how we can have better control knobs for this behaviour after gauging the impact on not relying on the cluster resources

@renuy renuy added priority/important-soon Must be staffed and worked on currently or soon. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes a defect or unexpected behavior carvel accepted This issue should be considered for future work and that the triage process has been completed priority/important-soon Must be staffed and worked on currently or soon.
Projects
Status: Prioritized Backlog
Development

No branches or pull requests

5 participants