Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include default template rules for Knative services #668

Open
praveenrewar opened this issue Jan 11, 2023 · 1 comment
Open

Include default template rules for Knative services #668

praveenrewar opened this issue Jan 11, 2023 · 1 comment
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.

Comments

@praveenrewar
Copy link
Member

praveenrewar commented Jan 11, 2023

Describe the problem/challenge you have
Versioned resources (with a generated name) are not taken into account for Knative services

Describe the solution you'd like
It would be great if kapp's default deploy config would be aware of knatives's references to Secrets and ConfigMaps
Slack thread

We can add template rules like one below for knative services to make kapp aware of CMs and Secrets.

# Manage versioned configmap into serving.knative.dev/v1
templateRules:
- resourceMatchers:
  - apiVersionKindMatcher: {apiVersion: v1, kind: ConfigMap}
  affectedResources:
    objectReferences:    
    - path: [spec, template, spec, volumes, {allIndexes: true}, configMap]    
      resourceMatchers:
      - apiVersionKindMatcher: {apiVersion: serving.knative.dev/v1, kind: Service}

Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@praveenrewar praveenrewar added enhancement This issue is a feature request carvel triage This issue has not yet been reviewed for validity carvel accepted This issue should be considered for future work and that the triage process has been completed and removed carvel triage This issue has not yet been reviewed for validity labels Jan 11, 2023
@mamachanko
Copy link
Contributor

As it might go overlooked, there are now tests for default template rules too.

@renuy renuy added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Feb 6, 2023
@renuy renuy added priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.
Projects
Status: Unprioritized
Development

No branches or pull requests

3 participants