Introduce DiffResources struct #665
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that we save and use newRs is imperfect, but not fixed now.
|
This is a first take, I'll try to integrate this into my PR to demonstrate that it actually helps :) |
|
Thanks for the PR! Will take a closer look at this. |
criztovyl
commented
Jan 2, 2023
| ExistingResources, NewResources versionedResources | ||
| ExistingResourcesGrouped map[string][]ctlres.Resource | ||
|
|
||
| newRs []ctlres.Resource |
There was a problem hiding this comment.
saving newRs is only a workaround for RenewableResources, I would prefer a different approach, but did not want to spend to much time here for the moment :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
See #635
Which issue(s) this PR fixes:
Fixes #635
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: