-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kapp shows "update" operation for ConfigMap that has no changes #603
Comments
The actual deployment of the not-really-changed ConfigMap is very fast, less than a second:
|
Kapp version 0.51.0 behaves the same, so this is not a very new bug. |
Hi @ChristianCiach! I am not able to reproduce the issue with kapp version 0.52.0 and kubernetes version 1.24. Do you have any kapp config (like rebase rules) along with the manifest or are there any external factors that could effect this resource?
kapp adds annotations to store the original resource (kapp.k14s.io/original) and the diff md5 (kapp.k14s.io/original-diff-md5). |
Thank you for your fast response! Well, we do have a custom kapp config, but I can reproduce this issue even without those. This is very confusing. I will try to investigate this further tomorrow and I will report back then. |
There is something inside the ConfigMap contents that triggers this issue. It is a root-certiticate bundle and after stripping more and more certificates from the ConfigMap, the issue eventually disappears. I don't think the file is confidential, so I will upload it after a quick verification. |
Here you go: https://gist.github.com/ChristianCiach/3ac9b7261ab9b14d7cdefe7b171b542f Can you reproduce the issue when deploying this file using By the way, the file has been automatically created from a |
Yeah, I see what's happening. We add the |
According to #410 (comment) , adding
This issue seems to be purely cosmetic, so I am okay with not doing anything on my side for the time being,. |
It's true that adding the |
Thanks so far! I can confirm that adding the annotation removes the bogus |
What steps did you take:
I have a simple, static ConfigMap where kapp insists that deploying the ConfigMap will result in an
update
operation, although the ConfigMap is exactly the same as the deployed one. If I deploy the file multiple times in a row, kapp still announces theupdate
operation every time.What did you expect:
When the ConfigMap has not changed, kapp should not show an
update
operation.Anything else you would like to add:
Using
kapp deploy -c
shows the removal of an emptymetadata.annotations
element:I don't know where this
annotations
field comes from. The metadata of our ConfigMap does not include anannotations
field:Kapp seems to think that the absence of an
annotations
field is different from an empty one.Environment:
kapp --version
): kapp version 0.52.0/etc/os-release
): AlmaLinux 8.6 (Sky Tiger)kubectl version
):Server Version: version.Info{Major:"1", Minor:"24", GitVersion:"v1.24.1+k3s1", GitCommit:"0581808f5c160b0c0cafec5b8f20430835f34f44", GitTreeState:"clean", BuildDate:"2022-06-11T17:26:28Z", GoVersion:"go1.18.1", Compiler:"gc", Platform:"linux/amd64"}
Vote on this request
This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.
👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"
We are also happy to receive and review Pull Requests if you want to help working on this issue.
The text was updated successfully, but these errors were encountered: