Avoid listing labeled resources for newly created app #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumaritanushree
requested review from
renuy,
praveenrewar,
sethiyash and
100mik
12 tasks
cppforlife
reviewed
Dec 14, 2022
… all resources from server
|
The changes themselves look good to me! |
kumaritanushree
force-pushed
the
avoid-list-labledRes-for-newApp
branch
from
73aace8
to
db92f4d
Compare
praveenrewar
reviewed
Jan 9, 2023
kumaritanushree
force-pushed
the
avoid-list-labledRes-for-newApp
branch
from
db92f4d
to
167c827
Compare
100mik
approved these changes
Jan 18, 2023
praveenrewar
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When we deploy an app, we first list the labeled resources (GVs) and then try to get the non labeled resources one by one one that are not found in the first step. When an app is deployed for the first time, the first step would always return nil.
This PR has changes to avoid listing labeled resources for newly created app
Which issue(s) this PR fixes:
Fixes #599
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: