Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff UI explains how to read it #580

Open
mamachanko opened this issue Aug 17, 2022 · 5 comments
Open

Diff UI explains how to read it #580

mamachanko opened this issue Aug 17, 2022 · 5 comments
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed documentation This issue indicates a change to the docs should be considered enhancement This issue is a feature request priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.

Comments

@mamachanko
Copy link
Contributor

mamachanko commented Aug 17, 2022

Describe the problem/challenge you have

The content of the Diff UI --diff-ui-alpha of kapp 0.52.0 is super helpful, but not intuitive to read.

Describe the solution you'd like

@kumaritanushree explained to me how to read it. I really liked her explanation and now I understand it better. Maybe it could be helpful to add a similar explanation to the Diff UI's page itself.


Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@mamachanko mamachanko added carvel triage This issue has not yet been reviewed for validity enhancement This issue is a feature request labels Aug 17, 2022
@rohitagg2020
Copy link
Contributor

Thanks @mamachanko for pointing it out. --diff-ui-alpha is an advanced feature. We will see how to enrich the command/documentation to add more context.

@mamachanko
Copy link
Contributor Author

Actually, now that I am looking at it again, I don't think that the existing explanation that is displayed by the Diff UI is lacking per se. But I say that after I have grokked it.

Changes are sorted in order that they will be applied. They will be applied in parallel within their group. Each change lists other changes that it will wait for before being applied.

@praveenrewar
Copy link
Member

Actually, now that I am looking at it again, I don't think that the existing explanation that is displayed by the Diff UI is lacking per se. But I say that after I have grokked it.

💯
I had faced the same issue initially, but once I understood the working of it, the statement "Changes are sorted ..." made complete sense to me.

I think that we can add an example in the docs and add a link to that example along with the explanation on the ui. Even though this is an advanced feature, it definitely helps into getting some insights into how kapp orders changes.

@renuy renuy added documentation This issue indicates a change to the docs should be considered carvel accepted This issue should be considered for future work and that the triage process has been completed priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. and removed carvel triage This issue has not yet been reviewed for validity labels Aug 22, 2022
@renuy
Copy link
Contributor

renuy commented Aug 22, 2022

  1. Enhance diff-ui-alpha to explaining the output
  2. Alternatively, add documentation around this feature.

@mamachanko
Copy link
Contributor Author

Even though this is an advanced feature

I understand that --diff-ui-alpha is considered off the happy path, but when things aren't happy it can safe your life day. Like it did for me last week. I could not explain why the installation of TAP waited forever until I checked the Diff UI. And, indeed, the SecretExport with the registry credentials was upserted after TAP's PackageInstall. I would never have figured that out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed documentation This issue indicates a change to the docs should be considered enhancement This issue is a feature request priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.
Projects
Status: To Triage
Development

No branches or pull requests

4 participants