Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error handling in kctrl package release command #1552

Open
goshkis opened this issue Apr 27, 2024 · 0 comments · May be fixed by #1553
Open

Fix error handling in kctrl package release command #1552

goshkis opened this issue Apr 27, 2024 · 0 comments · May be fixed by #1553
Labels
bug This issue describes a defect or unexpected behavior carvel-accepted This issue should be considered for future work and that the triage process has been completed priority/important-soon Must be staffed and worked on currently or soon.

Comments

@goshkis
Copy link

goshkis commented Apr 27, 2024

What steps did you take:

❯ kctrl package release --chdir "carvel-packages/my-package-name" --version "0.0.1" --yes --repo-output ../../package-repository

[...skipped...]
Building images and resolving references
	    | $ ytt -f /var/folders/t2/ypy2b3v55g163rqdg934k2pr0000gp/T/kapp-controller-fetch-template-[...skipped...]
An imgpkg bundle consists of all required manifests bundled into an OCI image.
This image is pushed to a registry and consumed by the package.
Pushing imgpkg bundle
	    | $ imgpkg push -b [...skipped...]:build-1714175591 -f ./bundle-[...skipped...]:build-1714175591-2627758157 --tty=true
	    | dir: .
	    | dir: .imgpkg
	    | file: .imgpkg/images.yml
[...skipped...]
	    | Pushed '[...skipped...]@sha256:4525b5ee06.......41dcf7801'
	    | Succeeded

Succeeded

❯ ls package-repository/
pkgrepo-build.yml

^^^ No package content

What happened:
kctrl package release ... --repo-output ... command is silently ignoring errors from releaseResources function.
Say, if incompatible ytt version is installed, this command will not yield any errors but no content will be written to the destination.

What did you expect:
Expected error in this specific environment:

	    | Succeeded

kctrl: Error: exit status 1: ytt:
  Error: unknown flag: --data-values-schema-inspect

Anything else you would like to add:
n/a

Environment:
n/a


Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@goshkis goshkis added bug This issue describes a defect or unexpected behavior carvel-triage This issue has not yet been reviewed for validity labels Apr 27, 2024
@goshkis goshkis linked a pull request Apr 27, 2024 that will close this issue
5 tasks
@renuy renuy added carvel-accepted This issue should be considered for future work and that the triage process has been completed priority/important-soon Must be staffed and worked on currently or soon. and removed carvel-triage This issue has not yet been reviewed for validity labels May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes a defect or unexpected behavior carvel-accepted This issue should be considered for future work and that the triage process has been completed priority/important-soon Must be staffed and worked on currently or soon.
Projects
Status: Prioritized Backlog
Development

Successfully merging a pull request may close this issue.

2 participants