Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: __init__() got an unexpected keyword argument 'do_exit' #133

Closed
gangefors opened this issue May 5, 2020 · 3 comments
Closed

Comments

@gangefors
Copy link

gangefors commented May 5, 2020

pylint 2.5.1 changed the lint.Run class definition and rename the parameter do_exit to exit.
According to pylint-dev/pylint#3554 this is a revert of an incorrectly named parameter.

INTERNALERROR>   File "/home/stefanga/projects/oe-fwrt/.tox/scripts/lib/python3.5/site-packages/pytest_pylint/plugin.py", line 174, in pytest_collection_finish
INTERNALERROR>     result = lint.Run(args_list, reporter=reporter, do_exit=False)
INTERNALERROR> TypeError: __init__() got an unexpected keyword argument 'do_exit'

To get the latest version of pytest-pylint to work one must lock the pylint dependency to <2.5.1.

@gangefors
Copy link
Author

gangefors commented May 5, 2020

I would argue that it's pylint that has broken their API which has been stable since 2.0 was released.
pylint-dev/pylint#3590

So this issue was just created for others that to find that have the same issue as we had in our CI pipelines.

@gangefors
Copy link
Author

The issue will be fixed with a deprecation notice in the upcoming 2.5.2 release.
pylint-dev/pylint@25223a9

@carsongee
Copy link
Owner

This is now resolved with https://pypi.org/project/pytest-pylint/0.17.0/ that was just released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants