AWS public_url missing region when using non default region

[AnrichVS]

Hi,

Please see changes made here - #2439

This doesn't account for cases where valid_subdomain is true, and this code is executed:

if valid_subdomain
  s3_subdomain = @uploader.fog_aws_accelerate ? "s3-accelerate" : "s3"
  "#{protocol}://#{@uploader.fog_directory}.#{s3_subdomain}.amazonaws.com/#{encoded_path}"
else
...

This generates an invalid URL if your bucket isn't in the default region.

The fix (I'll make a pull request if if I can find time) -

region = @uploader.fog_credentials[:region].to_s
# if directory is a valid subdomain, use that style for access
if valid_subdomain
  s3_subdomain = if @uploader.fog_aws_accelerate
                                "s3-accelerate"
                              else
                                (region =='' || region == DEFAULT_S3_REGION) ? 's3' : "s3.#{region}"
                              end
  "#{protocol}://#{@uploader.fog_directory}.#{s3_subdomain}.amazonaws.com/#{encoded_path}"
else
...