aws_attributes broken for ActiveSupport::OrderedOptions

[kapcod]

Hello.

A common way to load CarrierWave config is from yml file using Rails.application.config_for method. This method returns object of class ActiveSupport::OrderedOptions which behaves similar to OpenStruct but responds to .call and returns nil for .call.

This line

carrierwave-aws/lib/carrierwave/storage/aws_options.rb

Line 46 in 09c5baa

attributes.respond_to?(:call) ? attributes.call : attributes

uses respond_to?(:call) to check if aws_attributes is proc which is broken in this case. I suggest checking it using is_a?(Proc) which will be more correct. On the other side it will break the "duck type" approach, so not sure what's the right solution here.