Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update jQuery #591

Closed
fmichonneau opened this issue May 12, 2020 · 6 comments
Closed

update jQuery #591

fmichonneau opened this issue May 12, 2020 · 6 comments

Comments

@fmichonneau
Copy link
Contributor

make sure we upgrade jQuery (it looks like it's being used by the theme, and inline for showing the Google calendar in the correct time zone).

@maneesha
Copy link
Collaborator

Thanks @fmichonneau
I can update what's used for the calendar time zone.

I'm not sure how to update the theme though.

@maneesha
Copy link
Collaborator

#601 removes jquery from the calendar view.

As discussed with @fmichonneau this week, jquery is loaded by the site theme so we will wait until the theme is updated.

@fmichonneau
Copy link
Contributor Author

I opened sphinx-doc/sphinx#7696 to report the need to upgrade on the sphinx template.

@maneesha
Copy link
Collaborator

@fmichonneau It looks like the theme has been updated. Is this OK to close?

@maneesha
Copy link
Collaborator

It was called in one more place as we recently added in another calendar view. #636 takes care of that.

@fmichonneau
Copy link
Contributor Author

thanks Maneesha!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants