Skip to content

Fix: throw error if the "file-url" parameter is not set #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 24, 2022
Merged

Fix: throw error if the "file-url" parameter is not set #9

merged 2 commits into from
Jan 24, 2022

Conversation

pzhlkj6612
Copy link
Contributor

Original:

> Run ...
Error: The file-url input was not set.
Downloading file:
	url: 
	name: Not set
	location: .
	MD5: 
	SHA256: 
Error: Invalid URL

Gotcha: core.setFailed (code) didn't block the execution.

New:

> Run ...
Error: Input required and not supplied: file-url

pzhlkj6612 and others added 2 commits January 20, 2022 07:13

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Owner

@carlosperate carlosperate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this is good to merge too 👍
Thanks @pzhlkj6612!

@carlosperate carlosperate merged commit fd64e71 into carlosperate:master Jan 24, 2022
@pzhlkj6612 pzhlkj6612 deleted the fileURL-is-required-param-0 branch January 25, 2022 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants