Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature gate icons #46

Open
Stefanuk12 opened this issue Feb 22, 2024 · 1 comment
Open

Feature gate icons #46

Stefanuk12 opened this issue Feb 22, 2024 · 1 comment

Comments

@Stefanuk12
Copy link

As you have acknowledged, having so many icons causes rust-analyzer to lag. To fix this, you can gate each icon into its own feature flag. If you reach over the maximum features, you can group icons instead and do it that way.

@carloskiki
Copy link
Owner

Yes, this crate is the cause which instigated limits on crate features: https://blog.rust-lang.org/2023/10/26/broken-badges-and-23k-keywords.html.

The only obvious way I see of partitioning icons with feature flags would be on a per-library basis. This feels somewhat of a coarse grain method, but I could get behind it as it will improve UX.

If you have time, I would encourage you to open a PR and try your hand at implementing per-library features. I would be happy to review it :), but I do not have the time to implement it myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants