Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update composer.lock to fix Guzzle Issue #2111 #78

Closed
mouson opened this issue Dec 21, 2018 · 1 comment
Closed

update composer.lock to fix Guzzle Issue #2111 #78

mouson opened this issue Dec 21, 2018 · 1 comment

Comments

@mouson
Copy link

mouson commented Dec 21, 2018

use php 7.3 to start.php will show

PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in ......

guzzle package fix this problem in guzzle/guzzle#2111 , please update composer.lock to apply this change
@carlosflorencio carlosflorencio mentioned this issue Dec 22, 2018
Closed
@carlosflorencio
Copy link
Owner

Hi,

Can you try this PR to see if it fixes the issue?
#79

Would be good to confirm if it continues to work with older php versions (e.g 7.0,7.1,7.2) but don't have the time right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Guzzle version carlosflorencio/laracasts-downloader
2 participants
@mouson @carlosflorencio