Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Migrate cli to ESM #926

Merged
merged 11 commits into from Sep 29, 2022
Merged

♻️ Migrate cli to ESM #926

merged 11 commits into from Sep 29, 2022

Conversation

carloscuesta
Copy link
Owner

@carloscuesta carloscuesta commented Sep 27, 2022

Description

This PR updates the gitmoji-cli to an ESM so we can update a lot of the dependencies that we're using.

Thanks @aaditmshah for the help! 😊

Tests

  • All tests passed.

Pending

  • Migrate getConfiguration to avoid using require

@carloscuesta carloscuesta changed the title ♻️ Migrate to cli to ESM ♻️ Migrate cli to ESM Sep 27, 2022
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Base: 93.08% // Head: 92.82% // Decreases project coverage by -0.26% ⚠️

Coverage data is based on head (3dc0b23) compared to base (2782bd6).
Patch coverage: 92.30% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #926      +/-   ##
==========================================
- Coverage   93.08%   92.82%   -0.27%     
==========================================
  Files          29       29              
  Lines         246      251       +5     
  Branches       50       50              
==========================================
+ Hits          229      233       +4     
- Misses         17       18       +1     
Impacted Files Coverage Δ
src/commands/commit/withClient/index.js 100.00% <ø> (ø)
src/commands/commit/withHook/index.js 93.75% <ø> (ø)
src/commands/config/guard.js 100.00% <ø> (ø)
src/utils/getAbsoluteHooksPath.js 100.00% <ø> (ø)
src/utils/getDefaultCommitContent.js 93.33% <ø> (ø)
src/utils/configurationVault/getConfiguration.js 96.00% <87.50%> (-4.00%) ⬇️
src/cli.js 100.00% <100.00%> (ø)
src/commands/commit/prompts.js 62.50% <100.00%> (ø)
src/utils/emojisCache.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@carloscuesta carloscuesta merged commit b8baee0 into master Sep 29, 2022
@carloscuesta carloscuesta deleted the esmodules-migration branch September 29, 2022 17:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants