Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web-components]: card link icons have extra space to the right on RTL pages (v1) #11762

Open
2 tasks done
jkaeser opened this issue May 3, 2024 · 1 comment
Open
2 tasks done
Labels
bug Something isn't working dev Needs some dev work v1

Comments

@jkaeser
Copy link
Member

jkaeser commented May 3, 2024

Description

We use padding-right to set spacing for LTR documents, but this doesn't look right in RTL documents. We should use logical properties to fix this.

327783752-1381b3c9-3247-496b-ab4a-20f6a3649ded

See Olivia's original comment: #11760 (comment)

Component(s) impacted

dds-card-footer
dds-card-cta-footer

Browser

Chrome

Carbon for IBM.com version

v1.x

Severity

Severity 3 = The problem is visible or noticeable to users but does not impede the usability or functionality. Affects minor functionality, has a workaround.

Application/website

AEM

Package

@carbon/ibmdotcom-web-components, @carbon/ibmdotcom-styles

CodeSandbox example

none

Steps to reproduce the issue (if applicable)

No response

Release date (if applicable)

No response

Code of Conduct

@jkaeser jkaeser added bug Something isn't working dev Needs some dev work v1 labels May 3, 2024
@m4olivei
Copy link
Contributor

m4olivei commented May 3, 2024

It's odd that this bug is present. I'd expect the rtlcss tool to take care of this for v1. I'd love to know why rtlcss is missing this 🤔 .

I also wonder if it's getting missed in the same way for the CDN builds vs. Storybook b/c they use Rollup vs. Webpack respectively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dev Needs some dev work v1
Projects
Status: No status
Development

No branches or pull requests

2 participants