Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[carbon-web-component]: cds-button styling #11758

Open
2 tasks done
davidnixon opened this issue May 1, 2024 · 0 comments
Open
2 tasks done

[carbon-web-component]: cds-button styling #11758

davidnixon opened this issue May 1, 2024 · 0 comments
Labels
bug Something isn't working dev Needs some dev work

Comments

@davidnixon
Copy link

Description

  • danger tertiary/ghost button styled incorrectly

Component(s) impacted

cds-button
default button with kind set to danger-ghost storybook

I think the issue is here

/**
* Danger tertiary button.
*/
DANGER_TERTIARY = 'danger-tertiary',
/**
* Danger ghost button,
*/
DANGER_GHOST = 'danger-ghost',

Since this works <cds-button kind="danger--ghost">Danger ghost</cds-button>
But something like

import { BUTTON_KIND} from '@carbon/web-components/es/components/button/button';

<cds-button :kind="BUTTON_KIND.DANGER_GHOST">Danger ghost</cds-button>

does not. The defs should have an extra - like danger--ghost

Browser

Chrome

Carbon for IBM.com version

v2.0.28

Severity

Severity 3 = The problem is visible or noticeable to users but does not impede the usability or functionality. Affects minor functionality, has a workaround.

Application/website

Carbon components for Vue - wrapping web comppnets

Package

@carbon/web-components

CodeSandbox example

Cannot recreate in sandbox - BUTTON_KIND needs update

Steps to reproduce the issue (if applicable)

No response

Release date (if applicable)

No response

Code of Conduct

@davidnixon davidnixon added bug Something isn't working dev Needs some dev work labels May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dev Needs some dev work
Projects
Status: No status
Development

No branches or pull requests

1 participant