Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cta-block]: Add CSS Shadow Part #11750

Open
andy-blum opened this issue Apr 26, 2024 · 0 comments
Open

[cta-block]: Add CSS Shadow Part #11750

andy-blum opened this issue Apr 26, 2024 · 0 comments
Assignees
@andy-blum
Labels
adopter: AEM used when component or pattern will be used by this adopter Feature request A new adopter requested feature owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants package: web components Work necessary for the IBM.com Library web components package severity 4 Affects minor functionality, no workaround needed v1

Comments

@andy-blum
Copy link
Member

andy-blum commented Apr 26, 2024 •
edited

The problem

As described in #11673, the cta-block component has a large amount of internal padding. This particular component has caused problems in the document flow on ibm.com. We'd like to add a CSS Shadowpart to this component to be able to remove that padding from global styles.

The solution

Add a part attribute to the shadowroot's .bx--content-layout element.
@andy-blum andy-blum added the Feature request A new adopter requested feature label Apr 26, 2024
@andy-blum andy-blum self-assigned this Apr 26, 2024
@andy-blum andy-blum added severity 4 Affects minor functionality, no workaround needed v1 package: web components Work necessary for the IBM.com Library web components package adopter: AEM used when component or pattern will be used by this adopter owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants labels Apr 26, 2024
@bruno-amorim bruno-amorim mentioned this issue May 7, 2024
Closed
This was referenced May 8, 2024
Closed
Merged
kodiakhq bot pushed a commit that referenced this issue May 8, 2024
@andy-blum
feat(cta-block): add CSS shadowpart (#11777)
fc2860d 
Replaces #11774 

### Related Ticket(s)

[ADCMS-4976](https://jsw.ibm.com/browse/ADCMS-4976)

### Description

As per #11750

Adding a `part` attribute to the shadowroot's `.bx--content-layout` element so that it can be styled outside the shadow tree and have its padding manipulated if needed. 

![image](https://github.com/carbon-design-system/carbon-for-ibm-dotcom/assets/7583437/ea8efe3f-db89-412e-9bbd-723008d0c3a3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andy-blum andy-blum

Labels
adopter: AEM used when component or pattern will be used by this adopter Feature request A new adopter requested feature owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants package: web components Work necessary for the IBM.com Library web components package severity 4 Affects minor functionality, no workaround needed v1
Projects
Carbon for IBM.com
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andy-blum