Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[parent-visibility-mixin]: dds-video imports dds-tab component #11749

Open
andy-blum opened this issue Apr 26, 2024 · 0 comments
Open

[parent-visibility-mixin]: dds-video imports dds-tab component #11749

andy-blum opened this issue Apr 26, 2024 · 0 comments
Labels
adopter: AEM used when component or pattern will be used by this adopter bug Something isn't working dev Needs some dev work owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants package: web components Work necessary for the IBM.com Library web components package severity 3 Affects minor functionality, has a workaround

Comments

@andy-blum
Copy link
Member

andy-blum commented Apr 26, 2024 •
edited

https://jsw.ibm.com/browse/ADCMS-4975

Description

Importing the dds-video-player component brings along dds-tab for the ride.

Component(s) impacted

Any component using the parent-visibility mixin or extending/importing one of those components.

CodeSandbox example

https://codepen.io/andy-blum/pen/abxMKRm/10cd7d5f6087037b036dbb833767de49
@andy-blum andy-blum added bug Something isn't working dev Needs some dev work adopter: AEM used when component or pattern will be used by this adopter owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants severity 3 Affects minor functionality, has a workaround package: web components Work necessary for the IBM.com Library web components package labels Apr 26, 2024
This was referenced May 1, 2024
Closed
Merged
kodiakhq bot pushed a commit that referenced this issue May 6, 2024
@m4olivei
[v1] fix(parent-visibility): decouple tab from parent visibility (#11761
8437444 
)

### Related Ticket(s)

Closes #11749

### Description

This decouples `C4DTab` from `ParentVisibilityMixin`, which avoids the sideeffect of registering the `c4d-tab` component, when you're otherwise just making use of `ParentVisibilityMixin`.

### Changelog

**Changed**

- Avoids referencing `C4DTab` from `ParentVisibilityMixin` by duplicating the event name.

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
adopter: AEM used when component or pattern will be used by this adopter bug Something isn't working dev Needs some dev work owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants package: web components Work necessary for the IBM.com Library web components package severity 3 Affects minor functionality, has a workaround
Projects
Carbon for IBM.com
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(parent-visibility): decouple tab from parent visibility m4olivei/carbon-for-ibm-dotcom
1 participant
@andy-blum