Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data-table]: radio buttons should not include check all option and selecting individual rows does not trigger toolbar #11667

Open
2 tasks done
kennylam opened this issue Mar 25, 2024 · 1 comment · May be fixed by #11685
Open
2 tasks done

[data-table]: radio buttons should not include check all option and selecting individual rows does not trigger toolbar #11667

kennylam opened this issue Mar 25, 2024 · 1 comment · May be fixed by #11685
Assignees
@sangeethababu9223
Labels
bug Something isn't working dev Needs some dev work package: carbon web components

Comments

@kennylam
Copy link
Member

Description

When radio buttons are used, the check all option should not be available as only one per group is selectable. Additionally, selecting radio buttons does not activate the table toolbar.

image (1)

image (2)

Component(s) impacted

data-table

Browser

Chrome, Safari, Firefox, Microsoft Edge

Carbon for IBM.com version

v2.5.0

Severity

Severity 2 = Aspects of design is broken, and impedes users in a significant way, but there is a way to complete their tasks. Affects major functionality, has a workaround.

Application/website

@carbon/web-components

Package

@carbon/web-components

CodeSandbox example

https://web-components.carbondesignsystem.com/?path=/story/components-datatable-selection--with-radio-selection

Steps to reproduce the issue (if applicable)

No response

Release date (if applicable)

No response

Code of Conduct
@kennylam kennylam added bug Something isn't working dev Needs some dev work package: carbon web components labels Mar 25, 2024
@sangeethababu9223 sangeethababu9223 self-assigned this Mar 25, 2024
This was referenced Mar 26, 2024
Closed
Open
@sangeethababu9223
Copy link
Member

Table toolbar is needed only when we are choosing multiple rows and with radio button we can only choose one row at a time, hence the batch action toolbar is not needed here. The same behaviour can be seen in the carbon/react data table also with radio button option.

The select all option is now being hidden with hide-checkbox attribute added manually to the element in storybook, this can be updated if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangeethababu9223 sangeethababu9223

Labels
bug Something isn't working dev Needs some dev work package: carbon web components
Projects
Carbon for IBM.com
Status: Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(data-table): radio button all selection option disabled sangeethababu9223/carbon-for-ibm-dotcom
2 participants
@kennylam @sangeethababu9223