Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web Components Template] Enable base stylesheet and page specific assets directory that houses SCSS partial and images #15

Open
proeung opened this issue Aug 27, 2021 · 6 comments
Assignees
Labels
adopter: Innovation Team used when component or pattern will be used by this adopter adopter support dev Needs some dev work Feature request A new adopter requested feature follow-up: adopter hacktoberfest icebox used for all issues in the Icebox pipeline. Stalebot ignores these issues when this label is added. package: web components Work necessary for the IBM.com Library web components package

Comments

@proeung
Copy link
Contributor

proeung commented Aug 27, 2021

The problem

  • While developing the landing page for Watson Orchestrate, we realized that there are additional styles that are needed in order for us to assemble a landing page that matches the design.
  • Here's an example of the added styles that we've implemented for the Watson Orchestrate Landing page (https://github.ibm.com/Putra-Bonaccorsi/web-components-for-ei/blob/master/src/assets/scss/app.scss).
  • This feature allows adopters to easily build and contribute out boilerplate templates that can be used within the ibm.com EI content ecosystem and makes this project the go-to place to adopt landing page designs (eg. Explainer, Solution, etc) for different products.

The solution

  • Enable a /assets directory within each template page (eg. /src/pages/page2/assets)
  • Adjust the current Webpack configs to watch, live-reload, and build the assets.

Additional information

cc: @jwitkowski79

@proeung proeung added the Feature request A new adopter requested feature label Aug 27, 2021
@RobertaJHahn RobertaJHahn added the dev Needs some dev work label Aug 31, 2021
@RobertaJHahn
Copy link

@proeung Is this a temporary solution until AEM is in place?

@proeung
Copy link
Contributor Author

proeung commented Aug 31, 2021

@RobertaJHahn Not particularly. This is just an improvement ticket that allows adopters like myself (HC) to utilize this template application and be able to define specific add-on styling that's needed on a particular page template. This work is something that my team can help contribute back, but certainly not a high priority.

@RobertaJHahn RobertaJHahn added adopter support adopter: Innovation Team used when component or pattern will be used by this adopter package: web components Work necessary for the IBM.com Library web components package labels Sep 1, 2021
@RobertaJHahn
Copy link

Linda asks that Brittany and Shaun are looped into the discussions to avoid confusion and ensure the work fits in with their strategy. Putra will do this and comment with the result into this issue.

@proeung
Copy link
Contributor Author

proeung commented Sep 22, 2021

Following up with @jwitkowski79 and Annmarie Avila to see if this is something the team would like to continue with.

@RobertaJHahn
Copy link

@proeung the last message posted on this issue is Sept 22. Do you have any news? Can we close?

@proeung
Copy link
Contributor Author

proeung commented Nov 9, 2021

@RobertaJHahn There's no update regarding this issue. I think we can move it to the "Icebox" pipeline for now and revisit it in the new year.

@RobertaJHahn RobertaJHahn added the icebox used for all issues in the Icebox pipeline. Stalebot ignores these issues when this label is added. label Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adopter: Innovation Team used when component or pattern will be used by this adopter adopter support dev Needs some dev work Feature request A new adopter requested feature follow-up: adopter hacktoberfest icebox used for all issues in the Icebox pipeline. Stalebot ignores these issues when this label is added. package: web components Work necessary for the IBM.com Library web components package
Projects
None yet
Development

No branches or pull requests

5 participants