Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emit select event on checkbox or radio button activity #1450

Merged
merged 2 commits into from Aug 17, 2022
Merged

emit select event on checkbox or radio button activity #1450

merged 2 commits into from Aug 17, 2022

Conversation

naegelin
Copy link
Contributor

Proposed solution to #1449

Implementation follows existing click:row--expand pattern.

No backwards-compatibility issues AFIAK.

metonym
metonym approved these changes Aug 17, 2022
View reviewed changes
Copy link
Collaborator

@metonym metonym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a cut-and-dry change. Nice work.

@metonym metonym merged commit 3048712 into carbon-design-system:master Aug 17, 2022
@metonym metonym mentioned this pull request Aug 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metonym metonym metonym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@naegelin @metonym