Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question]: Why does the custom overflow menu closes on click #2814

Closed
brampeirs opened this issue Mar 14, 2024 · 1 comment
Closed

[Question]: Why does the custom overflow menu closes on click #2814

brampeirs opened this issue Mar 14, 2024 · 1 comment

Comments

@brampeirs
Copy link

Detailed description

The overflow menu with custom template allows you to implement your own template. In our use case we are adding a list of checkboxes, a cancel and save button. The menu closes when clicked however. When looking at the storybook, there the issue is reproducable.

overflow.menu.with.custom.template.mov

Is this a feature request (new component, new icon), a bug, or a general issue?
[bug]

Is this issue related to a specific component?
overflow-menu-custom-pane.component.ts

What did you expect to happen? What happened instead? What would you like to see changed?
menu should not close, and we should be able to call close() on the menu ourselves.

What version of the Carbon Design System are you using?
5.20.2

Steps to reproduce the issue

storybook

Additional information

we currently get around this by removing the onClick logic via patch package.
and by calling the close method ourselves

@ViewChild(OverflowMenuDirective) overflowMenu?: OverflowMenuDirective;
 this.overflowMenu?.close();
@Akshat55
Copy link
Contributor

Akshat55 commented Apr 2, 2024

The custom overflow menu is deprecated as of v5. Instead, you should use toggletip or popover component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants