Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Close modal view button align issue, tag <cds-modal></cds-modal>, close button is coming down of the header. #2783

Closed
Harshavardhan-Kanoj opened this issue Feb 8, 2024 · 6 comments

Comments

@Harshavardhan-Kanoj
Copy link

Harshavardhan-Kanoj commented Feb 8, 2024

Detailed description

Modal view close button alignment issue

Describe in detail the issue you're having.

Is this a feature request (new component, new icon), a bug, or a general issue?

Is this issue related to a specific component?

What did you expect to happen? What happened instead? What would you like to see changed?

What browser are you working in?

What version of the Carbon Design System are you using?

What offering/product do you work on? Any pressing ship or release dates we should be aware of?

Steps to reproduce the issue

  1. Step one
  2. Step two
  3. Step three
  4. etc.

Additional information

  • Screenshots or code
  • Notes
@Harshavardhan-Kanoj Harshavardhan-Kanoj changed the title Close modal view button align issue, tag <cds-modal></cds-modal> [BUG] Close modal view button align issue, tag <cds-modal></cds-modal> Feb 8, 2024
@Akshat55
Copy link
Contributor

Akshat55 commented Feb 8, 2024

This has been addressed in PR #2776, please try updating to the latest version of @carbon/styles.

@Akshat55 Akshat55 closed this as completed Feb 8, 2024
@Harshavardhan-Kanoj
Copy link
Author

I am still seeing this issue after upgrading carbon components to version v5.16.4

@Harshavardhan-Kanoj Harshavardhan-Kanoj changed the title [BUG] Close modal view button align issue, tag <cds-modal></cds-modal> [BUG] Close modal view button align issue, tag <cds-modal></cds-modal>, close button is coming down of the header. Feb 12, 2024
@Akshat55
Copy link
Contributor

That's odd... It works in storybook now and in my local project - Are you overriding the styles? What version of @carbon/styles are you using?

@Akshat55 Akshat55 reopened this Feb 12, 2024
@Akshat55
Copy link
Contributor

@Harshavardhan-Kanoj Are you still having this issue?

@Harshavardhan-Kanoj
Copy link
Author

Yes, I am .

@Akshat55
Copy link
Contributor

Could you please post a code sandbox demo of this? I cannot replicate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants