Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File uploader not disabling and not calling form onChangeCallback #2450

Merged

Conversation

Licen-it
Copy link
Contributor

@Licen-it Licen-it commented Feb 9, 2023

Closes #2073
Closes #2449

Changelog

Changed

  • implemented setDisabledState for file uploader so that reactive form disable will work
  • fixed the issue file uploader was not calling onChangeCallback

@Licen-it Licen-it requested a review from a team as a code owner February 9, 2023 17:21
@netlify
Copy link

netlify bot commented Feb 9, 2023

Deploy Preview for carbon-components-angular ready!

Name Link
🔨 Latest commit 8ffb322
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-angular/deploys/63e677102e2da50008863151
😎 Deploy Preview https://deploy-preview-2450--carbon-components-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@zvonimirfras zvonimirfras merged commit 1991bc5 into carbon-design-system:master Feb 10, 2023
@github-actions
Copy link

🎉 This PR is included in version 4.69.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 5.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Licen-it Licen-it deleted the file-uploader-issue branch February 14, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants