Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pie): uncaught exception on pie and donut chart load #1784

Merged

Conversation

markchou0225
Copy link
Contributor

@markchou0225 markchou0225 commented Mar 19, 2024

Updates

Demo screenshot or recording

Before (uncaught promise):
https://deploy-preview-1771--carbon-charts-core.netlify.app/?path=/story/simple-charts-donut--donut

After:
https://deploy-preview-1784--carbon-charts-react.netlify.app/?path=/story/simple-charts-donut--donut-centered

@markchou0225 markchou0225 requested review from theiliad and a team as code owners March 19, 2024 14:24
Copy link

netlify bot commented Mar 19, 2024

Deploy Preview for carbon-charts-core ready!

Name Link
🔨 Latest commit 2fda8c1
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-core/deploys/65f9a8ce61c7400008599ac2
😎 Deploy Preview https://deploy-preview-1784--carbon-charts-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 19, 2024

Deploy Preview for carbon-charts-react ready!

Name Link
🔨 Latest commit 2fda8c1
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-react/deploys/65f9a8ce9008e20007377615
😎 Deploy Preview https://deploy-preview-1784--carbon-charts-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 19, 2024

Deploy Preview for carbon-charts-angular ready!

Name Link
🔨 Latest commit 2fda8c1
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-angular/deploys/65f9a8ce63ed51000873e89b
😎 Deploy Preview https://deploy-preview-1784--carbon-charts-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@markchou0225 markchou0225 force-pushed the bug/1783-uncaught-promise branch 2 times, most recently from 1f73fec to 78b3761 Compare March 19, 2024 14:48
@markchou0225 markchou0225 changed the title WIP: fix(pie): uncaught exception on pie and donut chart load fix(pie): uncaught exception on pie and donut chart load Mar 19, 2024
@markchou0225
Copy link
Contributor Author

Hi @theiliad,

This bug is introduced in PR #1771 (v1.14.8), sorry for causing this side effect 😿

@theiliad theiliad merged commit 560af6f into carbon-design-system:master Mar 19, 2024
4 checks passed
@theiliad
Copy link
Member

Hi @theiliad,

This bug is introduced in PR #1771 (v1.14.8), sorry for causing this side effect 😿

thanks for the fix 🙌🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Uncaught (in promise) rejection from DonutChart
2 participants