Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(app): lerna 6.6.1 support #1543

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

nstuyvesant
Copy link
Contributor

Updates

  • Upgraded lerna to 6.6.1
  • Added options to lerna.json
  • Added yarn config setting required by Netlify
  • Changed Netlify env to use Python 2.7 which is required in order to build node-sass for Angular < 12

Review checklist (for reviewers only)

  • Demos all features
  • Documented/annotated
  • Matches UI/UX specs
  • Meets the code style guide
  • Accessible
  • Mobile first (responsive)
  • RTL support (bidirectional text)
  • Performant (limited bloat)

@nstuyvesant nstuyvesant requested review from theiliad, Akshat55 and a team as code owners April 20, 2023 16:15
@nstuyvesant nstuyvesant requested review from zvonimirfras and removed request for a team April 20, 2023 16:15
@netlify
Copy link

netlify bot commented Apr 20, 2023

Deploy Preview for carbon-charts-react ready!

Name Link
🔨 Latest commit b47b91c
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-react/deploys/6441652cf1e5fd0008797d70
😎 Deploy Preview https://deploy-preview-1543--carbon-charts-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 20, 2023

Deploy Preview for carbon-charts-core ready!

Name Link
🔨 Latest commit b47b91c
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-core/deploys/6441652c3912b500084d5f99
😎 Deploy Preview https://deploy-preview-1543--carbon-charts-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 20, 2023

Deploy Preview for carbon-charts-angular ready!

Name Link
🔨 Latest commit b47b91c
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-angular/deploys/6441652cae37d60008a0498c
😎 Deploy Preview https://deploy-preview-1543--carbon-charts-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@theiliad theiliad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theiliad theiliad merged commit a172305 into carbon-design-system:master Apr 21, 2023
4 checks passed
@nstuyvesant nstuyvesant deleted the feat-1542 branch May 1, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants