Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): keep tooltip hidden if legend truncation is set to none #1471

Merged
merged 1 commit into from Dec 6, 2022
Merged

fix(core): keep tooltip hidden if legend truncation is set to none #1471

merged 1 commit into from Dec 6, 2022

Conversation

Akshat55
Copy link
Collaborator

fix #1470

Updates

  • Check legend truncation type to see if tooltip should be shown.
    • If legend truncation type is set to none then tooltip is not shown since it is redundant
  • Removed unused variable (line 405)
  • Emit tooltip events only if tooltip was shown on hover (Copied same logic to mousemove & mouseleave)

Demo screenshot or recording

image

Review checklist (for reviewers only)

  • Demos all features
  • Documented/annotated
  • Matches UI/UX specs
  • Meets the code style guide
  • Accessible
  • Mobile first (responsive)
  • RTL support (bidirectional text)
  • Performant (limited bloat)

@Akshat55 Akshat55 requested review from theiliad and a team as code owners November 22, 2022 19:19
@Akshat55 Akshat55 requested review from zvonimirfras and removed request for a team November 22, 2022 19:19
@theiliad theiliad merged commit 1c5e555 into carbon-design-system:master Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theiliad theiliad theiliad approved these changes

@zvonimirfras zvonimirfras Awaiting requested review from zvonimirfras zvonimirfras is a code owner automatically assigned from carbon-design-system/carbon-charts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Legend tooltip should not be shown if legend truncation type is set to none
2 participants
@Akshat55 @theiliad