Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: thumbnail hover bugs #1456

Merged
merged 1 commit into from Oct 25, 2022
Merged

fix: thumbnail hover bugs #1456

merged 1 commit into from Oct 25, 2022

Conversation

mattrosno
Copy link
Member

Closes carbon-design-system/carbon-platform#1432

Reported carbon-design-system/carbon-platform#1315

Updates

  • Makes sure white divider lines show up on hover for bar stacked, gauge, heat map, and tree map thumbnails

Demo screenshot or recording

Hovering:

image

image

image

image

Review checklist (for reviewers only)

  • Demos all features
  • Documented/annotated
  • Matches UI/UX specs
  • Meets the code style guide
  • Accessible
  • Mobile first (responsive)
  • RTL support (bidirectional text)
  • Performant (limited bloat)

@mattrosno mattrosno requested review from theiliad, Akshat55 and a team as code owners October 24, 2022 16:36
@mattrosno mattrosno requested review from zvonimirfras, alisonjoseph, andreancardona and jeanservaas and removed request for a team October 24, 2022 16:36
theiliad
theiliad approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@theiliad theiliad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theiliad theiliad merged commit 48dde5d into carbon-design-system:master Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theiliad theiliad theiliad approved these changes

@Akshat55 Akshat55 Awaiting requested review from Akshat55

@zvonimirfras zvonimirfras Awaiting requested review from zvonimirfras zvonimirfras is a code owner automatically assigned from carbon-design-system/carbon-charts

@alisonjoseph alisonjoseph Awaiting requested review from alisonjoseph

@andreancardona andreancardona Awaiting requested review from andreancardona

@jeanservaas jeanservaas Awaiting requested review from jeanservaas

Assignees
No one assigned
Labels
type: docs 📖
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update thumbnails from #1315
2 participants
@mattrosno @theiliad