Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): allow users to 'escape' axis tooltip in heatmap #1454

Merged
merged 1 commit into from Oct 20, 2022

Conversation

Akshat55
Copy link
Collaborator

fix #1453

Updates

  • Accessibility fix, allows users to escape (hide) the tooltip for HEATMAP axis
  • When tooltip is hidden, the axis tick will remain highlighted
    • Going to the next or previous tick will show the tooltip again

Demo screenshot or recording

image

Review checklist (for reviewers only)

  • Demos all features
  • Documented/annotated
  • Matches UI/UX specs
  • Meets the code style guide
  • Accessible
  • Mobile first (responsive)
  • RTL support (bidirectional text)
  • Performant (limited bloat)

@Akshat55 Akshat55 requested review from theiliad and a team as code owners October 20, 2022 18:29
@Akshat55 Akshat55 requested review from zvonimirfras and removed request for a team October 20, 2022 18:29
Copy link
Member

@theiliad theiliad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theiliad theiliad merged commit d6873e2 into carbon-design-system:master Oct 20, 2022
@theiliad theiliad added type: bug 🐛 Something isn't working type: a11y ♿ labels Oct 20, 2022
@theiliad theiliad added this to In progress in Q4 - 2022 via automation Oct 20, 2022
@theiliad theiliad moved this from In progress to Done in Q4 - 2022 Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: a11y ♿ type: bug 🐛 Something isn't working
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

[Accessibility]: axis tooltip should be hidden when user presses Escape for HEATMAP
2 participants