Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(angular): add angular 14 support #1450

Merged
merged 1 commit into from Sep 27, 2022
Merged

feat(angular): add angular 14 support #1450

merged 1 commit into from Sep 27, 2022

Conversation

Akshat55
Copy link
Collaborator

fix #1445

Updates

  • Adds angular 14 package as peer dependency
  • Adds rxjs v7 as a peer dependency

Review checklist (for reviewers only)

  • Demos all features
  • Documented/annotated
  • Matches UI/UX specs
  • Meets the code style guide
  • Accessible
  • Mobile first (responsive)
  • RTL support (bidirectional text)
  • Performant (limited bloat)

@Akshat55 Akshat55 requested review from theiliad and a team as code owners September 26, 2022 23:48
@Akshat55 Akshat55 requested review from zvonimirfras and removed request for a team September 26, 2022 23:48
theiliad
theiliad approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@theiliad theiliad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theiliad theiliad added this to Closed in Q3- 2022 Sep 27, 2022
@theiliad theiliad merged commit 5e8f4ce into carbon-design-system:master Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theiliad theiliad theiliad approved these changes

@zvonimirfras zvonimirfras Awaiting requested review from zvonimirfras zvonimirfras is a code owner automatically assigned from carbon-design-system/carbon-charts

Assignees
No one assigned
Labels
affects: dependencies package: angular
Projects
No open projects
Q3- 2022
Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: @carbon/charts-angular library do not work with latest node.js (16.17.0)
2 participants
@Akshat55 @theiliad