Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): wordcloud should not render if value is not a number #1449

Merged
merged 2 commits into from Sep 26, 2022
Merged

fix(core): wordcloud should not render if value is not a number #1449

merged 2 commits into from Sep 26, 2022

Conversation

theiliad
Copy link
Member

this PR adds a check where if the value field provided is not a number, it'll stop the rendering and throw an error

@theiliad theiliad requested review from Akshat55 and a team as code owners September 26, 2022 14:42
@theiliad theiliad requested review from zvonimirfras and removed request for a team September 26, 2022 14:42
Akshat55
Akshat55 requested changes Sep 26, 2022
View reviewed changes
packages/core/src/components/graphs/wordcloud.ts Outdated Show resolved Hide resolved
packages/core/src/components/graphs/wordcloud.ts Outdated Show resolved Hide resolved
@theiliad theiliad merged commit 822f813 into carbon-design-system:master Sep 26, 2022
@theiliad theiliad deleted the wc-fix branch September 26, 2022 20:36
@theiliad theiliad added the type: bug 🐛 Something isn't working label Sep 26, 2022
@theiliad theiliad added this to Closed in Q3- 2022 Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akshat55 Akshat55 Akshat55 approved these changes

@zvonimirfras zvonimirfras Awaiting requested review from zvonimirfras zvonimirfras is a code owner automatically assigned from carbon-design-system/carbon-charts

Assignees
No one assigned
Labels
type: bug 🐛 Something isn't working
Projects
No open projects
Q3- 2022
Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@theiliad @Akshat55