fix(core): add missing properties to AxisOptions interface #1432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theiliad
requested changes
Sep 14, 2022
Comment on lines
+127
to
+138
| /** | ||
| * should be set to `true` for the | ||
| * left axis to be the primary axis | ||
| */ | ||
| main?: boolean; | ||
| /** | ||
| * used to map data on the secondary axis | ||
| */ | ||
| correspondingDatasets?: Array<string>; |
There was a problem hiding this comment.
Hi @metonym, we should probably find a way to have this only affect combo charts, since they mostly wouldn't apply to others
There was a problem hiding this comment.
- created a
ComboChartAxisOptionsinterface - updated
ComboChartOption.axesto useComboChartAxisOptions
metonym
force-pushed
the
fix-types-axis-options
branch
from
8891c22
to
8b492e0
Compare
theiliad
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1413
The
AxisOptionsinterface is missingmainandcorrespondingDatasetsproperties to support dual-axes charts.Updates
Demo screenshot or recording
Review checklist (for reviewers only)