#661@patch: Take class selector escaping into account. #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petejodo
commented
Nov 21, 2022
| const TAG_NAME_REGEXP = /^[a-zA-Z0-9-]+/; | ||
| const ID_REGEXP = /#[A-Za-z][-A-Za-z0-9_]*/g; | ||
| const CSS_ESCAPE_REGEXP = /(?<!\\):/g; |
There was a problem hiding this comment.
this escape should be more than just for : but don't know if I can just have it be any arbitrary character or a set of characters that can be escaped like [:#&...] in which case I'd have to go look up what characters those are but I'm a bit time-constrained right now
|
Thank you for your contribution @petejodo! 🙂 I have made a commit to include any escaped character. I also added some more unit tests. I feel pretty confident in that this should work as there is good test coverage, so I will therefore release it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is definitely not the best way of doing this but it does seem to fix the issue #661. This is more of a proof of concept or pathfinder for how to fix the issue properly. See the issue for more details.