#204@minor: Add support for HTMLAnchorElement. #641
Conversation
…gs related to blob urls.
capricorn86
force-pushed
the
task/204-support-html-anchor-element
branch
from
15e4296
to
c54734d
Compare
|
Nice contribution @IGx89! 🌟 I have done some improvements to performance. It is the same logic, but will improve performance as the URL does not need to be reinitialized unless the "href" is changed. There was also some problems with the handling of "blob" urls, which is hard to understand in the specs. Chrome doesn't seem to cater for the case, and FF added support for blob urls in v49 (reference). How I interpret the specs, the idea is that property changes on the URL object should be ignored if it is a "blob" url with an opaque path as they are not valid on the URL. This is also how FF seem to have implemented it. Please review the changes in the commit. Once you have done that, I am happy to release 🙂 |
|
@capricorn86 thanks! Looks great. Good teamwork :). |
Resolves #204