#628@patch: Handle style setter in HTMLElement. #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capricorn86
requested changes
Oct 24, 2022
| * @see https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/style#setting_styles | ||
| */ | ||
| public set style(cssText: string | CSSStyleDeclaration) { | ||
| this.setAttribute('style', typeof cssText === 'string' ? <string>cssText : ''); |
There was a problem hiding this comment.
Suggested change
| this.setAttribute('style', typeof cssText === 'string' ? <string>cssText : ''); | |
| this.style.cssText = cssText; |
We have to parse the CSS string before setting it (e.g. element.style = 'invalid: invalid' won't work).
jledentu
force-pushed
the
element-style-setter
branch
from
b84713f
to
58d0751
Compare
capricorn86
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a setter on
HTMLElement.stylethe reproduce the behaviour of DOM implementations, as explained in #628.This also fixes another difference between happy-dom and browser implementations: setting
nullor''asstyle(or incssText) shouldn't remove thestyleattribute.Since TypeScript forces a value returned by a getter to be assignable to a setter (see microsoft/TypeScript#42425), the
stylesetter accepts aCSSStyleDeclarationbut then resets thecssText, as implemented in some browsers.Closes #628