Pop keys from registered after calling unregister #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capricorn86
previously approved these changes
Oct 6, 2022
|
Thanks for contributing @luca992! 🙂 Sorry for not looking into this PR earlier. There has been a lot going on. The build is failing because the commit message doesn't follow the format defined in the contribution documentation. If you change the commit message by doing a git amend to something in style with Then I will merge and release this directly. |
…kes it impossible to register Happy DOM globally again after unregistering it.
|
👍 should be all good now. |
capricorn86
approved these changes
Oct 6, 2022
rudywaltz
pushed a commit
to rudywaltz/happy-dom
that referenced
this pull request
Oct 7, 2022
…age that makes it impossible to register Happy DOM globally again after unregistering it.
rudywaltz
pushed a commit
to rudywaltz/happy-dom
that referenced
this pull request
Oct 7, 2022
…age that makes it impossible to register Happy DOM globally again after unregistering it.
rudywaltz
pushed a commit
to rudywaltz/happy-dom
that referenced
this pull request
Oct 7, 2022
…age that makes it impossible to register Happy DOM globally again after unregistering it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise this sequence:
will throw:
Failed to register. Happy DOM has already been globally registered.