#517@minor: Implement dialog element. #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markgaze
force-pushed
the
task/517-add-dialog-element
branch
from
925ddad
to
efbd230
Compare
markgaze
force-pushed
the
task/517-add-dialog-element
branch
from
efbd230
to
e69a953
Compare
capricorn86
approved these changes
Jun 30, 2022
No worries! Thanks for merging and releasing! 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've implemented the
dialogelement inHTMLDialogElementand I think I've hooked it all up properly.I've left out the cancel event as I'm not entirely sure how it would be implemented in this repo. If you want me to do this then let me know and I'll have a look at getting it implemented.
Resolves #517