Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog element is not implemented #517

Closed
markgaze opened this issue Jun 24, 2022 · 1 comment · Fixed by #518
Closed

Dialog element is not implemented #517

markgaze opened this issue Jun 24, 2022 · 1 comment · Fixed by #518
Assignees
@markgaze

Comments

@markgaze
Copy link
Contributor

I am trying to test a <dialog> element (https://developer.mozilla.org/en-US/docs/Web/API/HTMLDialogElement) but this package only returns a HTMLElement so I cannot access showModal() or close().

(I'm about to create a PR for this but just logging so I have the issue ID for the commit)
markgaze added a commit to markgaze/happy-dom that referenced this issue Jun 24, 2022
@markgaze
capricorn86#517@minor: Implement dialog element.
925ddad
@markgaze markgaze mentioned this issue Jun 24, 2022
Merged
markgaze added a commit to markgaze/happy-dom that referenced this issue Jun 30, 2022
@markgaze
capricorn86#517@minor: Implement dialog element.
efbd230
markgaze added a commit to markgaze/happy-dom that referenced this issue Jun 30, 2022
@markgaze
capricorn86#517@minor: Implement dialog element.
e69a953
capricorn86 added a commit that referenced this issue Jun 30, 2022
@capricorn86
Merge pull request #518 from markgaze/task/517-add-dialog-element
cbe5b7a 
#517@minor: Implement dialog element.
@capricorn86
Copy link
Owner

Thanks again for your contribution @markgaze! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markgaze markgaze

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#517@minor: Implement dialog element. markgaze/happy-dom
2 participants
@markgaze @capricorn86