Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GlobalRegistrator has a bad conditional for unregister #509

Closed
pearofducks opened this issue Jun 18, 2022 · 1 comment
Closed

GlobalRegistrator has a bad conditional for unregister #509

pearofducks opened this issue Jun 18, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@pearofducks
Copy link
Contributor

https://github.com/capricorn86/happy-dom/blob/master/packages/global-registrator/src/GlobalRegistrator.ts#L29=

This incorrectly checks if the array is populated and throws, when it should be checking the negation.

pearofducks added a commit to pearofducks/happy-dom that referenced this issue Jun 18, 2022
capricorn86 added a commit that referenced this issue Jun 25, 2022
#509@patch: Fix GlobalRegistrator's unregister.
@capricorn86
Copy link
Owner

Thank you @pearofducks for fixing this! 🙂 I will close this issue now.

@capricorn86 capricorn86 added the bug Something isn't working label Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants