Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL is missing searchParams #452

Closed
Tracked by #520
oytuntez opened this issue Apr 10, 2022 · 4 comments
Closed
Tracked by #520

URL is missing searchParams #452

oytuntez opened this issue Apr 10, 2022 · 4 comments
Assignees
Labels
bug Something isn't working high priority

Comments

@oytuntez
Copy link

Hi there!

Thank you for the effort in this library – I am testing happy-dom to see if I can achieve some performance improvement over jsdom. Our case is more of a server-side rendering: we have a browser library that manipulates the existing DOM very very heavily (mutation observers, tree walkers, attribute modifications, node additions/removals etc). JSDom spends a lot of time in various places.

While testing happy-dom, I am encountering several things, I will be submitting them as issues here as I see them. Here is the first one.

URL object does not have a searchParams property, only search: https://developer.mozilla.org/en-US/docs/Web/API/URL/searchParams

@capricorn86 capricorn86 added bug Something isn't working high priority labels Apr 26, 2022
@capricorn86
Copy link
Owner

@Mas0nShi is fixing this in this PR 🙂

#520

@jackdomleo7
Copy link

Is there any update on this?

@kevinbarabash
Copy link

It looks like progress is on-going in that PR, but it's a pretty big change. I could put together a PR that just replaces URL.ts with node's built-in "url" module.

@capricorn86
Copy link
Owner

@oytuntez @jackdomleo7 @kevinbarabash A fix has now been released 🙂

You can read more about the release here:
https://github.com/capricorn86/happy-dom/releases/tag/v7.8.0

@capricorn86 capricorn86 self-assigned this Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority
Projects
None yet
Development

No branches or pull requests

4 participants