Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Java 11 baseline #1170

Open
12 of 15 tasks
caprica opened this issue Sep 23, 2022 · 3 comments
Open
12 of 15 tasks

Migrate to Java 11 baseline #1170

caprica opened this issue Sep 23, 2022 · 3 comments

Comments

@caprica
Copy link
Owner

caprica commented Sep 23, 2022

Headline changes:

  • Java 11 baseline for vlcj 4.8.x
  • Java 11 baseline for vlcj-natives 4.8.x
  • Java 11 baseline for vlcj 5.0.x
  • Java 11 baseline for vlcj-natives 5.0.x
  • Use the Java Module System
  • Remove obsolete OsxFullScreenStrategy and vlcj-osx-stubs dependency
  • Refine the module exports in vlcj-natives and vlcj, including any necessary package restructuring to accommodate it
  • Move all examples in src/test/java to a 4.8 branch in the vlcj-examples project - or consider just deleting them as the 5.x examples will eventually become all that is needed. maintaining two branches just for examples is quite onerous
  • Java 11 baseline and modules for vlcj-javafx
  • Java 11 baseline and modules for vlcj-javafx-demo
  • Java 11 baseline and modules for vlcj-player
  • Java 11 baseline and modules for vlcj-native-streams
  • All other ancillary projects, like vlcj-subs, vlcj-info, vlcj-mrls and so on, check them all
  • vlcj-file-filters
  • vlcj-mrls

Scope does not necessarily include any rewriting to use new language features, like try with resources, lambdas and so on.

Consider backporting new 5.x native discovery.

@caprica caprica added the Task label Sep 23, 2022
@caprica caprica added this to the vlcj 4.8.0 Release milestone Sep 23, 2022
@caprica
Copy link
Owner Author

caprica commented Sep 24, 2022

The plan is to make an initial 4.8.0 release to garner feedback from users on any difficulties introduced by the switch to using the Java Module System.

@caprica caprica changed the title Migrate 4.x to Java 11 baseline Migrate to Java 11 baseline Sep 24, 2022
@caprica
Copy link
Owner Author

caprica commented Sep 24, 2022

Already need a 4.8.1 release to switch from non-modular JNA dependencies to jna-jpms and jna-platform-jpms instead.

@caprica
Copy link
Owner Author

caprica commented Dec 11, 2022

Potential issues around restricting access of vlcj-natives to vlcj only, e.g. libvlc_instance_t not exposed so MediaPlayer can not be sub-classed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant