Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soften requirement for pyyaml #43

Closed
theianrobertson opened this issue Mar 22, 2019 · 3 comments · Fixed by #44
Closed

Soften requirement for pyyaml #43

theianrobertson opened this issue Mar 22, 2019 · 3 comments · Fixed by #44

Comments

@theianrobertson
Copy link
Collaborator

There's a strict dependency on a specific version of pyyaml, but some times I'm trying to use this alongside other packages that may have a range. For example if I install pre-commit to my environment first, it installs the latest pyyaml:

https://github.com/pre-commit/pre-commit/blob/master/setup.cfg#L32

What are your thoughts on having a minimum version for pyyaml but leaving the max version out? Since this doesn't rely on a huge amount of the yaml package?

@fdosani
Copy link
Member

fdosani commented Mar 22, 2019

There was a security issue with PyYAML earlier: See Issue #25
I think the current pinned version should be the min. I see they are up to v5 now.

@theianrobertson
Copy link
Collaborator Author

Cool - What do you think about just having a min version in that case? Or do you want to keep a max?

@fdosani
Copy link
Member

fdosani commented Apr 2, 2019

can we peg to a min 5.1? I'm cool with doing that if that is OK?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants