feat: jwt profile grant #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pkg/oidc/authorization.go
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
- Coverage 13.09% 11.20% -1.90%
==========================================
Files 23 24 +1
Lines 962 1125 +163
==========================================
Hits 126 126
- Misses 834 997 +163
Partials 2 2
Continue to review full report at Codecov.
|
adlerhurst
reviewed
Sep 16, 2020
adlerhurst
approved these changes
Sep 16, 2020
adlerhurst
approved these changes
Sep 16, 2020
fix: key as string instead of bytes
adlerhurst
approved these changes
Sep 16, 2020
hifabienne
reviewed
Sep 16, 2020
Comment on lines
+92
to
+98
| // ScopesSupported: oidc.SupportedScopes, | ||
| // ResponseTypesSupported: responseTypes, | ||
| // GrantTypesSupported: oidc.SupportedGrantTypes, | ||
| // ClaimsSupported: oidc.SupportedClaims, | ||
| // IdTokenSigningAlgValuesSupported: []string{keys.SigningAlgorithm}, | ||
| // SubjectTypesSupported: []string{"public"}, | ||
| // TokenEndpointAuthMethodsSupported: |
There was a problem hiding this comment.
added TODO: add to config after updating Configuration interface for DiscoveryConfig
hifabienne
approved these changes
Sep 16, 2020
|
🎉 This PR is included in version 0.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.