You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What did you expect to happen?
The queue doesn't schedule another drain call if one is running.
What was the actual result?
The queue goes into an infinite loop.
I'm not sure this is necessarily a bug as queue is working as specified - if an empty task is pushed and it's idle, it drains. I only noticed it because in the priorityQueue tests, we have a test for this case, see tests/priorityQueue#L52. With the changes in #1790, the priorityQueuebehaves the same way as queue and goes into an infinite loop. We could add a check that if a drain call is running, not to schedule another one similar to what we do with q._process. Thoughts?
The text was updated successfully, but these errors were encountered:
What version of async are you using?
v3.2.3
Which environment did the issue occur in (Node/browser/Babel/Typescript version) node & browser
What did you do? Please include a minimal reproducible case illustrating issue.
What did you expect to happen?
The
queue
doesn't schedule anotherdrain
call if one is running.What was the actual result?
The
queue
goes into an infinite loop.I'm not sure this is necessarily a bug as
queue
is working as specified - if an empty task is pushed and it'sidle
, it drains. I only noticed it because in thepriorityQueue
tests, we have a test for this case, see tests/priorityQueue#L52. With the changes in #1790, thepriorityQueue
behaves the same way asqueue
and goes into an infinite loop. We could add a check that if adrain
call is running, not to schedule another one similar to what we do withq._process
. Thoughts?The text was updated successfully, but these errors were encountered: